kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

Fix runbook_url test #1011

Closed assafad closed 1 month ago

assafad commented 1 month ago

Fix runbook_url test to not expect the alert name as the URL suffix, as in some installations the alert name is not the URL suffix. e.g. in openshift the runbooks are in https://github.com/openshift/runbooks/tree/master/alerts/openshift-virtualization-operator, and the suffix is <alert-name>.md.

Release note:

None
avlitman commented 1 month ago

/lgtm

akrejcir commented 1 month ago

/retest

akrejcir commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [akrejcir] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akrejcir commented 1 month ago

Let's backport this, because tests are failing in older versions.

/cherry-pick release-v0.20

akrejcir commented 1 month ago

/cherry-pick release-v0.19

kubevirt-bot commented 1 month ago

@akrejcir: new pull request created: #1012

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1011#issuecomment-2244848927): >Let's backport this, because tests are failing in older versions. > >/cherry-pick release-v0.20 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 1 month ago

@akrejcir: new pull request created: #1013

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1011#issuecomment-2244849445): >/cherry-pick release-v0.19 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.