search

kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

Update common-templates to v0.29.2 #1016

Closed ksimon1 closed 3 months ago

ksimon1 commented 3 months ago

Update common-templates bundle to v0.29.2 Release note:

Update common-templates bundle to v0.29.2
ksimon1 commented 3 months ago

/cherrypick release-v0.20

kubevirt-bot commented 3 months ago

@ksimon1: once the present PR merges, I will cherry-pick it on top of release-v0.20 in a new PR and assign it to you.

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1016#issuecomment-2252036690): >/cherrypick release-v0.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ksimon1 commented 3 months ago

@geetikakay, @kbidarkar FYI we will be backporting the removal of win2k12 template to 4.16

akrejcir commented 3 months ago

Adding renovate is unrelated to this PR. Can you please split it? We have multiple PRs that update common-templates already, and it is unexpected to find another change in the same PR.

ksimon1 commented 3 months ago

I am testing renovate on my local fork :) The automation took my main with renovate config, I will remove it.

ksimon1 commented 3 months ago

/hold

ksimon1 commented 3 months ago

/hold cancel

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ksimon1 commented 3 months ago

@akrejcir fixed

jcanocan commented 3 months ago

Thanks @ksimon1! /lgtm

akrejcir commented 3 months ago

Thanks.

/approve

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [akrejcir] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 3 months ago

@ksimon1: new pull request created: #1017

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1016#issuecomment-2252036690): >/cherrypick release-v0.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.