api: Add a config option for vm-console-proxy and deprecate the feature gate

[akrejcir]

What this PR does / why we need it: These changes are in this PR:

• Deprecated the feature gate for vm-console-proxy. It is now ignored.
• Added a new field .spec.tokenGenerationService to configure if vm-console-proxy should be enabled or not.

Which issue(s) this PR fixes: Jira: https://issues.redhat.com/browse/CNV-45064

Release note:

- Added a new field: ".spec.tokenGenerationService" to configure if "vm-console-proxy" should be enabled or not.
- Deprecated the feature gate for `vm-console-proxy`. It is now ignored.

[akrejcir]

/cc @0xFelix @jcanocan @ksimon1

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[codingben]

/cc @0xFelix @jcanocan @ksimon1

Hi @akrejcir, why you don't cc me also? If I remember correctly, this was my change to add feature gate of vm-console-proxy [1]. Also Tekton operands.

cc @dominikholler

[1] https://github.com/kubevirt/ssp-operator/commit/8551c1dbd169cf51105b583d9ed96b5b634d1216

[akrejcir]

I only thought that pinging 3 reviewers was enough. It wasn't my intention to not mention you. Of course you can review this, all reviews are helpful.

Good idea to mention people that originally wrote the code that I've changed. I will do that in future PRs.

[akrejcir]

/retest

[jcanocan]

/cc @0xFelix @jcanocan @ksimon1

Hi @akrejcir, why you don't cc me also? If I remember correctly, this was my change to add feature gate of vm-console-proxy [1]. Also Tekton operands.

cc @dominikholler

[1] 8551c1d

@codingben Please add the lgtm tag when you are done with your review.

[codingben]

/cc @0xFelix @jcanocan @ksimon1

Hi @akrejcir, why you don't cc me also? If I remember correctly, this was my change to add feature gate of vm-console-proxy [1]. Also Tekton operands. cc @dominikholler [1] 8551c1d

@codingben Please add the lgtm tag when you are done with your review.

Usually in kubevirt/kubevirt we're waiting to get /lgtm and then asking to get /approve. From my point of view, it's already reviewed.

[akrejcir]

We need both, /lgtm and /approve, otherwise the bot will not merge the PR. I think, it is done so multiple people have a chance to look at a PR.

[jcanocan]

/lgtm