kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

CI: Use compatible tekton version v0.67 #1023

Closed akrejcir closed 1 month ago

akrejcir commented 1 month ago

What this PR does / why we need it: The newer tekton versions changed CRD names, and so the operator cannot find objects from a given CRD.

Release note:

None
akrejcir commented 1 month ago

/cc @codingben @ksimon1

ksimon1 commented 1 month ago

@akrejcir do you know why the e2e tests are failing?

codingben commented 1 month ago

I see this issue:

internal/controllers/setup.go:22:19: could not import kubevirt.io/ssp-operator/internal/operands/vm-console-proxy (-: # kubevirt.io/ssp-operator/internal/operands/vm-console-proxy
internal/operands/vm-console-proxy/reconcile.go:111:27: request.Instance.Spec.TokenGenerationService undefined (type "kubevirt.io/ssp-operator/api/v1beta2".SSPSpec has no field or method TokenGenerationService)) (typecheck)
    vm_console_proxy "kubevirt.io/ssp-operator/internal/operands/vm-console-proxy"

How it's related to this PR changes?

akrejcir commented 1 month ago

I forgot to commit vendor files in my previous PR. This PR fixes it: https://github.com/kubevirt/ssp-operator/pull/1024

akrejcir commented 1 month ago

/retest

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ksimon1 commented 1 month ago

/lgtm

akrejcir commented 1 month ago

We have 2 /lgtms, approving.

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [akrejcir] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment