Closed akrejcir closed 1 month ago
/cc @codingben @ksimon1
@akrejcir do you know why the e2e tests are failing?
I see this issue:
internal/controllers/setup.go:22:19: could not import kubevirt.io/ssp-operator/internal/operands/vm-console-proxy (-: # kubevirt.io/ssp-operator/internal/operands/vm-console-proxy
internal/operands/vm-console-proxy/reconcile.go:111:27: request.Instance.Spec.TokenGenerationService undefined (type "kubevirt.io/ssp-operator/api/v1beta2".SSPSpec has no field or method TokenGenerationService)) (typecheck)
vm_console_proxy "kubevirt.io/ssp-operator/internal/operands/vm-console-proxy"
How it's related to this PR changes?
I forgot to commit vendor files in my previous PR. This PR fixes it: https://github.com/kubevirt/ssp-operator/pull/1024
/retest
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
/lgtm
We have 2 /lgtm
s, approving.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: akrejcir
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: The newer tekton versions changed CRD names, and so the operator cannot find objects from a given CRD.
Release note: