search

kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

[release-v0.18] CI: Use compatible tekton version v0.67 #1027

Closed akrejcir closed 3 months ago

akrejcir commented 3 months ago

What this PR does / why we need it: The newer tekton versions changed CRD names, and so the operator cannot find objects from a given CRD.

Release note:

None
akrejcir commented 3 months ago

/cc @ksimon1 @codingben

ksimon1 commented 3 months ago

/lgtm

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
13 New issues
10 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

codingben commented 3 months ago

/test e2e-upgrade-functests

kubevirt-bot commented 3 months ago

@codingben: No presubmit jobs available for kubevirt/ssp-operator@release-v0.18

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1027#issuecomment-2261343920): >/test e2e-upgrade-functests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akrejcir commented 3 months ago

/retest

codingben commented 3 months ago

Hi, I see that functional tests passed. @akrejcir Can you please review it?

akrejcir commented 3 months ago

/approve

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/release-v0.18/OWNERS)~~ [akrejcir] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codingben commented 3 months ago

Is it possible to override SonarCloud Code Analysis?

codingben commented 3 months ago

/override SonarCloud Code Analysis

kubevirt-bot commented 3 months ago

@codingben: codingben unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1027#issuecomment-2262666545): >/override SonarCloud Code Analysis Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codingben commented 3 months ago

@akrejcir @ksimon1 @0xFelix Can you please override it?

0xFelix commented 3 months ago

/override "SonarCloud Code Analysis"

kubevirt-bot commented 3 months ago

@0xFelix: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1027#issuecomment-2262775697): >/override "SonarCloud Code Analysis" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
0xFelix commented 3 months ago

@sarahbx Can you help with this? (SonarCloud Code Analysis)