fix: common-instancetypes: Clear URL when deploying from bundle

kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources

Apache License 2.0

29 stars 47 forks source link

fix: common-instancetypes: Clear URL when deploying from bundle #1033

Closed akrejcir closed 1 month ago

akrejcir commented 1 month ago

What this PR does / why we need it: Previously, this order of operations would trigger a bug:

set .spec.commonInstancetypes.url to a URL - The operator will deploy resources from the URL
unset .spec.commonInstancetypes.url - The operator will deploy resources from internal bundle
set .spec.commonInstancetypes.url to the same URL - The operator will ignore the resources and not deploy anything

Release note:

None

akrejcir commented 1 month ago

/cc @0xFelix @codingben

akrejcir commented 1 month ago

Yes, the comment is true, but the behavior is not correct in my opinion. It is very unexpected from the user's point of view. Even when user specifies the URL parameter, the operator will keep the resources from the internal bundle, ignoring the URL.

0xFelix commented 1 month ago

Can you add a test?

codingben commented 1 month ago

+1 unit test, was about also to comment, is it covered by unit tests?

akrejcir commented 1 month ago

I've added the test.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

akrejcir commented 1 month ago

/cherry-pick release-v0.20

kubevirt-bot commented 1 month ago

@akrejcir: new pull request created: #1035

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1033#issuecomment-2273159310): >/cherry-pick release-v0.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.