kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

makefile: use the same ginkgo version that is in go.mod #1128

Closed akrejcir closed 1 week ago

akrejcir commented 1 week ago

What this PR does / why we need it: Use the same ginkgo version in Makefile that is in go.mod.

Release note:

None
akrejcir commented 1 week ago

/cc @0xFelix @ksimon1 @codingben

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kubevirt-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akrejcir commented 1 week ago

Are you going to also update dependabot's config?

/approve

No, after this PR, dependabot does not need to be changed. Is there a config option for this use case?

0xFelix commented 1 week ago

https://github.com/kubevirt/ssp-operator/blob/567d9f5cce3a03f9c9167fcd8b94a549b82d362c/.github/dependabot.yml#L11

I was talking about this ignore. With this being merged, I think we can allow dependabot to update ginkgo now?

akrejcir commented 1 week ago

Good point. I forgot about that config even thought I've added it in PR #911 . It didn't work anyway. Dependabot last updated ginkgo in #1028 .