search

kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

Handle paginated results in e2e-upgrade-functests #794

Open 0xFelix opened 10 months ago

0xFelix commented 10 months ago

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What happened:

https://github.com/kubevirt/ssp-operator/blob/54285313efecb017c47744dda5b666bdfd4a1c56/automation/e2e-upgrade-functests/run.sh#L24C20-L24C86

This scripts queries for release branches and by default there is a limit of 30 items per page. Since dependabot started creating a lot of branches, the branches we are looking for are no longer returned on page one. This resulted in the CI failing.

See https://github.com/kubevirt/ssp-operator/pull/792

What you expected to happen:

The script should handle paginated results, see https://docs.github.com/en/rest/branches/branches?apiVersion=2022-11-28#list-branches--parameters

How to reproduce it:

Anything else we need to know?:

Environment:

kubevirt-bot commented 7 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

akrejcir commented 7 months ago

/remove-lifecycle stale

kubevirt-bot commented 4 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

akrejcir commented 4 months ago

/remove-lifecycle stale

kubevirt-bot commented 1 month ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 3 weeks ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

akrejcir commented 3 weeks ago

/remove-lifecycle rotten