kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

fix: Do not force IPv4 on metrics service #957

Closed akrejcir closed 6 months ago

akrejcir commented 7 months ago

What this PR does / why we need it: The service that exposes metrics used to force IPv4 protocol. It failed in clusters that have only IPv6.

Fixes: https://issues.redhat.com/browse/CNV-40159

Release note:

None
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

akrejcir commented 7 months ago

Holding until I verify it. /hold

akrejcir commented 6 months ago

The CI fails because of: https://issues.redhat.com/browse/CNV-40547

akrejcir commented 6 months ago

/retest

akrejcir commented 6 months ago

/unhold

akrejcir commented 6 months ago

/cc @ksimon1 @0xFelix

dominikholler commented 6 months ago

Please do not block merging on the verification.

kubevirt-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lyarwood commented 6 months ago

/lgtm

akrejcir commented 6 months ago

/cherry-pick release-v0.20

kubevirt-bot commented 6 months ago

@akrejcir: new pull request created: #965

In response to [this](https://github.com/kubevirt/ssp-operator/pull/957#issuecomment-2066141621): >/cherry-pick release-v0.20 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
akrejcir commented 6 months ago

/cherry-pick release-v0.19

kubevirt-bot commented 6 months ago

@akrejcir: new pull request created: #969

In response to [this](https://github.com/kubevirt/ssp-operator/pull/957#issuecomment-2069008913): >/cherry-pick release-v0.19 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.