search

kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

[release-v0.19] fix: Increase reconcile metric only if SSP CR was not changed #959

Closed kubevirt-bot closed 5 months ago

kubevirt-bot commented 5 months ago

This is an automated cherry-pick of #950

/assign akrejcir

None
kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/ssp-operator/blob/release-v0.19/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sonarcloud[bot] commented 5 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

akrejcir commented 5 months ago

/cc @0xFelix @jcanocan

jcanocan commented 5 months ago

Looks like the build failed: Error: internal/operands/common-templates/reconcile_test.go:350:18: undefined: metrics (typecheck)

openshift-ci[bot] commented 5 months ago

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 44d86e323b853b46c17ca8ef7dffa5bf0c6d2c12 link true /test images
ci/prow/e2e-functests 44d86e323b853b46c17ca8ef7dffa5bf0c6d2c12 link true /test e2e-functests
ci/prow/e2e-single-node-functests 44d86e323b853b46c17ca8ef7dffa5bf0c6d2c12 link true /test e2e-single-node-functests
ci/prow/e2e-upgrade-functests 44d86e323b853b46c17ca8ef7dffa5bf0c6d2c12 link true /test e2e-upgrade-functests
ci/prow/unittests 44d86e323b853b46c17ca8ef7dffa5bf0c6d2c12 link true /test unittests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
akrejcir commented 5 months ago

I will post a manual backport.

/close

kubevirt-bot commented 5 months ago

@akrejcir: Closed this PR.

In response to [this](https://github.com/kubevirt/ssp-operator/pull/959#issuecomment-2057072182): >I will post a manual backport. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.