kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

[release-v0.19] fix: Remove namespaceSelector from webhook definition #978

Closed akrejcir closed 4 months ago

akrejcir commented 4 months ago

This is a backport of: https://github.com/kubevirt/ssp-operator/pull/879

What this PR does / why we need it: The ValidatingWebhookConfiguration created by OLM can have namespaceSelector field set. We don't want it, because the webhook checks that there is only one SSP resource in the cluster.

Which issue(s) this PR fixes: Jira: https://issues.redhat.com/browse/CNV-36636

Release note:

None
sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/release-v0.19/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akrejcir commented 4 months ago

Waiting for QE to confirm that we want this.

/hold

akrejcir commented 4 months ago

QE wants this backport.

/unhold

akrejcir commented 4 months ago

/cc @ksimon1 @jcanocan

jcanocan commented 4 months ago

/lgtm