search

kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

chore: Do not commit generated files #983

Closed akrejcir closed 4 days ago

akrejcir commented 6 months ago

What this PR does / why we need it: This commit removes these generated files from the repository:

Instead of these files, the csv-generator uses the generated bundle directory.

This change will be useful in the future when we update operator-sdk, because then the generated files will contain a creation timestamp, which would be updated in every new PR.

Release note:

None
akrejcir commented 6 months ago

/cc @ksimon1 @0xFelix @jcanocan

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-ci[bot] commented 6 months ago

@akrejcir: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unittests 8cd2c0af31f5cf82d6e861052556fa2f5026bbc2 link true /test unittests
ci/prow/e2e-functests 8cd2c0af31f5cf82d6e861052556fa2f5026bbc2 link true /test e2e-functests
ci/prow/e2e-upgrade-functests 8cd2c0af31f5cf82d6e861052556fa2f5026bbc2 link true /test e2e-upgrade-functests
ci/prow/e2e-single-node-functests 8cd2c0af31f5cf82d6e861052556fa2f5026bbc2 link true /test e2e-single-node-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akrejcir commented 5 months ago

Holding until I figure out how to change the build process, so that image can be build in the CI by podman build Dockerfile.

/hold

kubevirt-bot commented 5 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 1 month ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot commented 4 days ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot commented 4 days ago

@kubevirt-bot: Closed this PR.

In response to [this](https://github.com/kubevirt/ssp-operator/pull/983#issuecomment-2452542046): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.