search

kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

common instancetypes: Deprecate operand #986

Closed lyarwood closed 5 months ago

lyarwood commented 5 months ago

What this PR does / why we need it:

Deployment of the common-instancetypes resources will be handled by virt-operator moving forward so we can finally deprecate the operand within SSP for removal in a future release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

Deployment of `common-instancetypes` using this operator is now deprecated and will be removed in a future release.
lyarwood commented 5 months ago

/retest-required /cc @akrejcir

Would you mind taking a look at this when you have time?

akrejcir commented 5 months ago

/lgtm

akrejcir commented 5 months ago

I think you need to run

make fmt vet container-build

that should regenerate need files.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

lyarwood commented 5 months ago

/cc @0xFelix

lyarwood commented 5 months ago

/retest-required

kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lyarwood commented 4 months ago

/cherry-pick release-v0.20