kubevirt / user-guide

This user guide will walk you through installation and various features.
https://kubevirt.io/user-guide
Apache License 2.0
64 stars 233 forks source link

Accessing Virtual Machines: Switch to cloudInitNoCloud #759

Closed 0xFelix closed 9 months ago

0xFelix commented 9 months ago

What this PR does / why we need it:

Replace instances of cloudInitConfigDrive / configDrive with cloudInitNoCloud / noCloud, since cloud-init NoCloud is the preferred way to deliver cloud-init configuration data and it is now supported by the access credentials api.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

None
kubevirt-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/user-guide/blob/main/OWNERS)~~ [cwilkers] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment