kubevirt / user-guide

This user guide will walk you through installation and various features.
https://kubevirt.io/user-guide
Apache License 2.0
64 stars 227 forks source link

volumes: move the discard passthrough documentation #785

Closed alicefr closed 4 months ago

alicefr commented 5 months ago

The discard passthrough feature is documented in kubevirt/kubevirt/docs/discard-passthrough.md, but it is missing in the user-guide.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

Document discard passthrough in the user-guide
alicefr commented 5 months ago

/cc @aburdenthehand

aburdenthehand commented 5 months ago

/lgtm Thanks @alicefr! Maybe we can merge #784 first and fix the ordering on this one.

alicefr commented 5 months ago

/lgtm Thanks @alicefr! Maybe we can merge #784 first and fix the ordering on this one.

Sure, I will probably need also to rebase this

mhenriks commented 4 months ago

/approve

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/user-guide/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment