image field in hook sidecar annotation is optional

tiraboschi commented 6 months ago

What this PR does / why we need it: with https://github.com/kubevirt/kubevirt/pull/11272 image field becomes optional in the hook sidecar annotation since, if omitted, virt-controller will now use a default sidecar-shim image built with other kubevirt images.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #775

Special notes for your reviewer: No to retrieve the version of the hook sidecar shim version from kubevirt CR, the virt-controller can now autonomously handle it.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

[X] Design: A design document was considered and is present (link) or not required
[X] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[X] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[X] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

image field in hook sidecar annotation is optional

alicefr commented 6 months ago

/approve

alicefr commented 6 months ago

/lgtm

kubevirt-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alicefr, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/user-guide/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubevirt / user-guide

image field in hook sidecar annotation is optional #786