Closed EdDev closed 12 hours ago
/lgtm
btw I hit these while changing all xrefs for #794 (there's also a (#register)
xref in both of these files that are in the same boat). If/when that merges it becomes moot but it makes sense to merge this in the interim. Thanks for the fix!
PR needs rebase.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Pull requests that are marked with lgtm
should receive a review
from an approver within 1 week.
After that period the bot marks them with the label needs-approver-review
.
/label needs-approver-review
@kubevirt-bot: The label(s) needs-approver-review
cannot be applied, because the repository doesn't have them.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dhiller
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten
Fixed through https://github.com/kubevirt/user-guide/pull/801
/close
@EdDev: Closed this PR.
/remove-label needs-approver-review
What this PR does / why we need it:
Fix links in the documentation of the network binding plugins.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: