Replace usage of DataVolume.spec.pvc with .storage

EduardGomezEscandell commented 5 months ago

What this PR does / why we need it: Replaces DataVolume PVC target with the newer storage target.

This is the modern API we want users to be using. It also allows for skipping certain parameters due to better defaults.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

kubevirt-bot commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

EduardGomezEscandell commented 5 months ago

/test all

kubevirt-bot commented 5 months ago

@EduardGomezEscandell: No jobs can be run with /test all. The following commands are available to trigger required jobs:

/test check-links-user-guide

In response to [this](https://github.com/kubevirt/user-guide/pull/798#issuecomment-2112101125): >/test all Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

alromeros commented 5 months ago

There is another reference to the PVC api here. Looks good otherwise!

alromeros commented 5 months ago

/lgtm

alromeros commented 5 months ago

/lgtm

aburdenthehand commented 5 months ago

/approve

EduardGomezEscandell commented 5 months ago

/cc @rmohr

phoracek commented 5 months ago

/approve

kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aburdenthehand, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/user-guide/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubevirt / user-guide

Replace usage of DataVolume.spec.pvc with .storage #798