kubevirt / user-guide

This user guide will walk you through installation and various features.
https://kubevirt.io/user-guide
Apache License 2.0
64 stars 235 forks source link

owners, user-guide: set up owners from sigs #819

Closed dhiller closed 4 months ago

dhiller commented 4 months ago

What this PR does / why we need it:

Since we have the sigs formed for the several topics, let's establish ownership of the sections by each respective sig.

This PR adds and OWNERS_ALIASES file to capture the several aliases, copying from kubevirt/kubevirt. Also it adds OWNERS that refer to those sig groups, so that the groups can own the changes to the user-guide themselves.

Also it removes some users from the reviewers section who haven't shown review activity for the last six months - this way we avoid assigning them to the reviews and getting reviews stalled.

See https://kubevirt.devstats.cncf.io/d/46/pr-reviews-by-contributor?orgId=1&var-period=d7&var-repo_name=kubevirt%2Fuser-guide&var-reviewers=%22davidvossel%22&var-reviewers=%22rmohr%22&var-reviewers=%22stu-gott%22

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer: /cc @aburdenthehand @cwilkers @alicefr

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

jean-edouard commented 4 months ago

@dhiller will we setup a job to open update PRs when OWNERS_ALIASES changes in kubevirt/kubevirt?

dhiller commented 4 months ago

@dhiller will we setup a job to open update PRs when OWNERS_ALIASES changes in kubevirt/kubevirt?

Yeah, I think automation around this would make much sense - not yet sure what exactly we want to do around this. I'd say we store lists inside community repo and sync from there

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/user-guide/blob/main/OWNERS)~~ [jean-edouard] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alicefr commented 4 months ago

/lgtm Many thanks @dhiller for the quick PR!

aburdenthehand commented 4 months ago

/lgtm Thanks for picking this up @dhiller

dhiller commented 4 months ago

/unhold

Noone has complained, so we seem to have reached silent consensus.