kubevirt / user-guide

This user guide will walk you through installation and various features.
https://kubevirt.io/user-guide
Apache License 2.0
64 stars 235 forks source link

installation: Add guide for using s390x developer builds #828

Closed jschintag closed 2 months ago

jschintag commented 3 months ago

What this PR does / why we need it:

Add instructions on how to use the nightly builds for s390x architecture.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer: I have considered making the arm64 section more generic instead, but ultimately decided it would make the instructions needlessly compilecated.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

Add instructions for using kubevirt s390x developer builds
dhiller commented 3 months ago

/cc

alicefr commented 3 months ago

/cc

alicefr commented 3 months ago

One small nit, otherwise looks good

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/cluster_admin/OWNERS](https://github.com/kubevirt/user-guide/blob/main/docs/cluster_admin/OWNERS)~~ [dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jschintag commented 2 months ago

Since i got no answer for the nit, i'll just go with arm already has it this way so it must be ok.

/unhold