kubevirt / user-guide

This user guide will walk you through installation and various features.
https://kubevirt.io/user-guide
Apache License 2.0
64 stars 235 forks source link

Update persistent TPM & UEFI page to clarify storageclass requirements #830

Open ianb-mp opened 3 months ago

ianb-mp commented 3 months ago

What this PR does / why we need it:

Update Persistent TPM and UEFI state to reflect the changes made in https://github.com/kubevirt/kubevirt/pull/11773

Also, small spelling fix: prerequesites -> prerequisites

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign iholder101, mhenriks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[docs/compute/OWNERS](https://github.com/kubevirt/user-guide/blob/main/docs/compute/OWNERS)** - **[docs/storage/OWNERS](https://github.com/kubevirt/user-guide/blob/main/docs/storage/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 3 months ago

Hi @ianb-mp. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ianb-mp commented 3 months ago

I was unsure if the following statement is still true - can anyone confirm?

Backend storage is currently incompatible with VM snapshot. It is planned to add snapshot support in the future.

akalenyu commented 3 months ago

I was unsure if the following statement is still true - can anyone confirm?

Backend storage is currently incompatible with VM snapshot. It is planned to add snapshot support in the future.

I think so - https://github.com/kubevirt/kubevirt/blob/effcb5b8e6fc951ec5c85ba47ad1daedc0173d79/pkg/virt-api/webhooks/validating-webhook/admitters/vmsnapshot-admitter.go#L166-L174 /cc @jean-edouard

kubevirt-bot commented 1 day ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

ianb-mp commented 1 day ago

@akalenyu @victortoso @jean-edouard could someone please review?

jean-edouard commented 1 day ago

Thank you @ianb-mp for this update. It looks good but needs to be reworked a bit to reflect most recent changes.