kubevirt / user-guide

This user guide will walk you through installation and various features.
https://kubevirt.io/user-guide
Apache License 2.0
64 stars 233 forks source link

mem-hotplug: update user-guide #833

Closed acardace closed 1 month ago

acardace commented 1 month ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

Update memory hotplug user guide
acardace commented 1 month ago

/cc @jean-edouard

vladikr commented 1 month ago

/approve Looks good to me in general, I only have one question about the 1Gi guest mem size requirement.

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/compute/OWNERS](https://github.com/kubevirt/user-guide/blob/main/docs/compute/OWNERS)~~ [vladikr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
acardace commented 1 month ago

/cc @jean-edouard can you take a look?