search

kubevirt / user-guide

This user guide will walk you through installation and various features.
https://kubevirt.io/user-guide
Apache License 2.0
64 stars 234 forks source link

completionTimeoutPerGiB: can be used to trigger post-copy migrations #834

Closed iholder101 closed 2 months ago

iholder101 commented 2 months ago

What this PR does / why we need it: completionTimeoutPerGiB can be used to either abort a migration or switch it to post-copy. This PR adds a documentation for the post-copy usage.

Release note:

NONE
iholder101 commented 2 months ago

/cc @vladikr @stu-gott

iholder101 commented 2 months ago

Thanks @fossedihelm! :) Done!

vladikr commented 2 months ago

Looking

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/compute/OWNERS](https://github.com/kubevirt/user-guide/blob/main/docs/compute/OWNERS)~~ [jean-edouard] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vladikr commented 2 months ago

Looks fine to me. I think we need to reduce this time out to ~150s /lgtm

iholder101 commented 2 months ago

Looks fine to me. I think we need to reduce this time out to ~150s

Makes perfect sense to me. Would you like me to make a PR to change that, or should we somehow figure out / test what's the best default here?

iholder101 commented 2 months ago

Thank @jean-edouard! :) Done. user-guides PRs are a great way to improve my English :smile:

can you PTAL? @vladikr @jean-edouard

jean-edouard commented 2 months ago

/unhold

vladikr commented 2 months ago

/lgtm

vladikr commented 2 months ago

Looks fine to me. I think we need to reduce this time out to ~150s

Makes perfect sense to me. Would you like me to make a PR to change that, or should we somehow figure out / test what's the best default here?

@iholder101 I think we can raise a PR and cc Jen for input. what do you think?

iholder101 commented 2 months ago

Looks fine to me. I think we need to reduce this time out to ~150s

Makes perfect sense to me. Would you like me to make a PR to change that, or should we somehow figure out / test what's the best default here?

@iholder101 I think we can raise a PR and cc Jen for input. what do you think?

Done: https://github.com/kubevirt/kubevirt/pull/12848 :)