search

kubevirt / user-guide

This user guide will walk you through installation and various features.
https://kubevirt.io/user-guide
Apache License 2.0
64 stars 234 forks source link

Change spec.running refs to runStrategy #849

Closed arnongilboa closed 3 weeks ago

arnongilboa commented 3 weeks ago

What this PR does / why we need it: Change deprecated spec.running references to runStrategy.

Which issue(s) this PR fixes: jira-ticket: https://issues.redhat.com/browse/CNV-45433

Release note:

Change deprecated spec.running references to runStrategy
iholder101 commented 3 weeks ago

Also, can you please also documentation regarding Once strategy to docs/compute/run_strategies.md? This can be done in a follow-up if you prefer

arnongilboa commented 3 weeks ago

Also, can you please also documentation regarding Once strategy to docs/compute/run_strategies.md? This can be done in a follow-up if you prefer

added

iholder101 commented 3 weeks ago

Thank you @arnongilboa! Looks great! /lgtm

phoracek commented 3 weeks ago

/approve

kubevirt-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/user-guide/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment