virtctl: Overhaul virtctl create vm docs

0xFelix commented 2 weeks ago

What this PR does / why we need it:

Overhaul the virtctl create vm docs by:

Adding documentation for generatin cloud-init user data
Adding documentation for the access credential flag
Adding documentation for the sysprep volume flag
Updating and extending the examples
Applying minor fixes throughout the file
Moving the creation of instance types and preferences into their own page

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

None

lyarwood commented 2 weeks ago

/cc

jcanocan commented 2 weeks ago

Great job! /lgtm

0xFelix commented 1 week ago

@aburdenthehand Updated the PR, PTAL!

aburdenthehand commented 1 week ago

/approve

kubevirt-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aburdenthehand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/user-guide/blob/main/OWNERS)~~ [aburdenthehand] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jcanocan commented 1 week ago

/lgtm

kubevirt / user-guide

virtctl: Overhaul virtctl create vm docs #851