search

kubevirt / vm-console-proxy

Proxy for VM console connection.
Apache License 2.0
9 stars 9 forks source link

fix: Fix owner references in created resources #101

Closed akrejcir closed 7 months ago

akrejcir commented 7 months ago

What this PR does / why we need it: Fix incorrect ownerReferences. Now the resources will be correctly cleaned up after the VM is deleted.

Which issue(s) this PR fixes:

Fixes: https://issues.redhat.com/browse/CNV-38845

Release note:

None
akrejcir commented 7 months ago

/cc @0xFelix @jcanocan

kubevirt-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/vm-console-proxy/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcanocan commented 7 months ago

/lgtm

akrejcir commented 6 months ago

/cherry-pick release-v0.4

kubevirt-bot commented 6 months ago

@akrejcir: new pull request created: #116

In response to [this](https://github.com/kubevirt/vm-console-proxy/pull/101#issuecomment-2031239241): >/cherry-pick release-v0.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
akrejcir commented 6 months ago

/cherry-pick release-v0.3

kubevirt-bot commented 6 months ago

@akrejcir: new pull request created: #117

In response to [this](https://github.com/kubevirt/vm-console-proxy/pull/101#issuecomment-2031257405): >/cherry-pick release-v0.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.