search

kubevirt / vm-console-proxy

Proxy for VM console connection.
Apache License 2.0
6 stars 9 forks source link

[release-v0.4] fix: Fix owner references in created resources #116

Closed kubevirt-bot closed 4 months ago

kubevirt-bot commented 4 months ago

This is an automated cherry-pick of #101

/assign akrejcir

None
kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-console-proxy/blob/release-v0.4/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcanocan commented 4 months ago

/lgtm

ksimon1 commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-functests 3a3d57acb080306a54ae287103b8b33bf3f9e8bf link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
akrejcir commented 4 months ago

This needs a manual fix.

/close

kubevirt-bot commented 4 months ago

@akrejcir: Closed this PR.

In response to [this](https://github.com/kubevirt/vm-console-proxy/pull/116#issuecomment-2031386312): >This needs a manual fix. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.