[release-v0.4] fix: Fix owner references in created resources

kubevirt / vm-console-proxy

Proxy for VM console connection.

Apache License 2.0

6 stars 9 forks source link

[release-v0.4] fix: Fix owner references in created resources #119

Closed akrejcir closed 4 months ago

akrejcir commented 4 months ago

Manual cherry-pick of: https://github.com/kubevirt/vm-console-proxy/pull/101

The manual change is in the test code, so that it compiles with older gomega and kubevirt.io/client-go.

Release note:

None

0xFelix commented 4 months ago

Same comment as on #120:

Can you put a list of conflicting files and a note explaining the required changes into the commit message? (e.g. what you wrote in the PR description)

akrejcir commented 4 months ago

Same comment as on #120:

Can you put a list of conflicting files and a note explaining the required changes into the commit message? (e.g. what you wrote in the PR description)

Done

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/vm-console-proxy/blob/release-v0.4/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

akrejcir commented 4 months ago

/retest

akrejcir commented 4 months ago

/cc @ksimon1 @jcanocan

jcanocan commented 4 months ago

/lgtm