make release-manifests command generates a manifest with an image tagged as "latest" (which is not available on quay.io)

kubevirt / vm-console-proxy

Proxy for VM console connection.

Apache License 2.0

5 stars 9 forks source link

make release-manifests command generates a manifest with an image tagged as "latest" (which is not available on quay.io) #152

Closed nestoracunablanco closed 12 hours ago

nestoracunablanco commented 1 week ago

What happened: After executing make deploy on a live Openshift cluster, the manifest is applied, but the image is not fetched. This occurs because the manifest specifies the "latest" tag, which is not present in the registry at https://quay.io/repository/kubevirt/vm-console-proxy.

What you expected to happen: The make deploy command deploys a fully functional vm-console-proxy to an Openshift cluster.

How to reproduce it (as minimally and precisely as possible): Run make deploy

Environment:

CRC version: 2.38.0+25b6eb
OpenShift version: 4.15.17

akrejcir commented 1 week ago

We know about this. make deploy is used during development in this flow:

Set environment variables IMG_REPOSITORY and IMG_TAG (or the variable IMG) to your development repository.
Run make build-container push-container to build the current code and push it into your development repository.
Run make deploy to install the development version.

akrejcir commented 1 week ago

If you want to install a released version, you can use the vm-console-proxy.yaml file from any released version: https://github.com/kubevirt/vm-console-proxy/releases

nestoracunablanco commented 4 days ago

@akrejcir, thank you for your answer. I have enhanced the README based on your comment.