API: Improve API and increase version to v1

kubevirt / vm-console-proxy

Proxy for VM console connection.

Apache License 2.0

9 stars 9 forks source link

API: Improve API and increase version to v1 #165

Closed akrejcir closed 3 months ago

akrejcir commented 3 months ago

What this PR does / why we need it: This PR does these changes:

Adds a new convenience field to the struct returned by /token endpoint.
Removes dependency on OpenShift from the API
Increases the API version to v1

Which issue(s) this PR fixes: Jira: https://issues.redhat.com/browse/CNV-45061

Release note:

- The /token endpoint returns a new field in the json:  expirationTimestamp.
- The format of the TLS profile in the ConfigMap changed to not depend on OpenShift struct.
- The version of the API was increased to v1.

akrejcir commented 3 months ago

/cc @0xFelix @jcanocan @ksimon1

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/vm-console-proxy/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

akrejcir commented 3 months ago

Do we need to deprecate the old API or ensure compatibility?

Otherwise looks fine

/approve

Previous API was alpha version, so in my opinion it's not needed.

jcanocan commented 3 months ago

Thanks for your efforts! Nice job! /lgtm