fix: correctly handle empty ciphers in TLS config file

kubevirt / vm-console-proxy

Proxy for VM console connection.

Apache License 2.0

9 stars 9 forks source link

fix: correctly handle empty ciphers in TLS config file #176

Closed akrejcir closed 2 months ago

akrejcir commented 2 months ago

What this PR does / why we need it: The ciphers field in the TLS config file has different meaning if it is Null or an empty array [].

Null means that we should enable default cipher suites.
Empty array [] means that we don't want to enable any cipher suites. Cipher suites for TLS 1.3 cannot be configured, so they are still enabled, even if empty array is passed.

Release note:

The "ciphers" field in the TLS config file has different meaning if it is "Null" or an empty array "[]".

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-console-proxy/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

akrejcir commented 2 months ago

/cc @0xFelix @codingben @jcanocan

akrejcir commented 2 months ago

After a discussion with Felix, I see that this PR is not needed.

/close

kubevirt-bot commented 2 months ago

@akrejcir: Closed this PR.

In response to [this](https://github.com/kubevirt/vm-console-proxy/pull/176#issuecomment-2288811257): >After a discussion with Felix, I see that this PR is not needed. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.