search

kubevirt / vm-console-proxy

Proxy for VM console connection.
Apache License 2.0
9 stars 9 forks source link

fix: watch directory instead of specific files #18

Closed akrejcir closed 1 year ago

akrejcir commented 1 year ago

What this PR does / why we need it: When watching a file, the watch ends when it is deleted, and there is no way to restart it.

Release note:

None
akrejcir commented 1 year ago

/retest

akrejcir commented 1 year ago

/cc @0xFelix @ksimon1 @lyarwood

akrejcir commented 1 year ago

A few nits and supernits, I'd also like to see some coverage of watching directories in filewatch_test.go. I assume functional tests would be a follow up for this?

I will add more tests.

akrejcir commented 1 year ago

Tests added.

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/vm-console-proxy/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lyarwood commented 1 year ago

/lgtm