search

kubevirt / vm-console-proxy

Proxy for VM console connection.
Apache License 2.0
9 stars 9 forks source link

fix: example-client: Token in subprotocol needs to be in base64 #28

Closed akrejcir closed 1 year ago

akrejcir commented 1 year ago

What this PR does / why we need it: The token that is needs to be base64 encoded.

Release note:

None
ksimon1 commented 1 year ago

/lgtm

akrejcir commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/vm-console-proxy/blob/main/OWNERS)~~ [akrejcir] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akrejcir commented 1 year ago

/cherry-pick release-v0.3

kubevirt-bot commented 1 year ago

@akrejcir: new pull request created: #30

In response to [this](https://github.com/kubevirt/vm-console-proxy/pull/28#issuecomment-1697587724): >/cherry-pick release-v0.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.