search

kubevirt / vm-console-proxy

Proxy for VM console connection.
Apache License 2.0
9 stars 9 forks source link

docs: Add information about "duration" API parameter #32

Closed akrejcir closed 1 year ago

akrejcir commented 1 year ago

What this PR does / why we need it: Added more information about the duration parameter.

Release note:

None
akrejcir commented 1 year ago

/cc @0xFelix

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/vm-console-proxy/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akrejcir commented 1 year ago

I will change one thing. /hold

akrejcir commented 1 year ago

/unhold

0xFelix commented 1 year ago

/lgtm