search

kubevirt / vm-import-operator

Operator for importing VMs from RHV to KubeVirt
Apache License 2.0
16 stars 23 forks source link

vSphere: always map machine type to q35 #429

Closed mansam closed 3 years ago

mansam commented 3 years ago

This overwrites the machine type that might be set by the template the VM is based on, in order to avoid the VM failing to start due to an unsupported machine type.

Signed-off-by: Sam Lucidi slucidi@redhat.com

kubevirt-bot commented 3 years ago

@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mansam commented 3 years ago

/retest

pkliczewski commented 3 years ago

@mansam Please take a look at test failure where:

Error converting guests: virt-v2v job vmimport.v2v.kubevirt.iorzll9 failed

we need to understand what is the reason.

mansam commented 3 years ago

Still trying to determine the cause of this test failure. The tests pass on my development machine, and all of the test vms use the same disk images via the fake vddk, so if guest conversion passes for one it should pass for all of them.

mansam commented 3 years ago

/retest

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jakub-dzon, mansam, pkliczewski To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-import-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment