search

kubevirt / vm-import-operator

Operator for importing VMs from RHV to KubeVirt
Apache License 2.0
16 stars 23 forks source link

Add optional AccessMode to StorageResourceMappingItem #438

Closed mansam closed 3 years ago

mansam commented 3 years ago

konveyor/virt-controller would like to be able to specify a supported access mode when creating storage/disk mappings. This adds an AccessMode field to the StorageResourceMappingItem, and adds support for mapping the AccessMode and VolumeMode in the vSphere provider.

AccessMode and VolumeMode will default respectively to ReadWriteOnce and Filesystem in the vSphere provider. The oVirt provider will take the access mode from the mapping if it's set, otherwise it will determine the access mode as it previously did.

kubevirt-bot commented 3 years ago

@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mansam, pkliczewski To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-import-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment