Closed mansam closed 3 years ago
@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: fdupont-redhat, mansam, pkliczewski
To complete the pull request process, please assign
You can assign the PR to them by writing /assign
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Fixes the VMWare client's
StopVM
to useShutdownGuest
instead ofPowerOff
. This will require the VMWare Tools to be installed on the guest.This uses the same polling mechanism as the oVirt provider to wait for the shutdown to complete, which can block for up to 5 minutes. I assume that since that's what the oVirt provider is doing that it's acceptable, but if not I have also worked on an alternative approach which involves setting a new condition and re-queuing the reconcile until the source VM powers off or times out.
Fixes https://github.com/kubevirt/vm-import-operator/issues/443
Signed-off-by: Sam Lucidi slucidi@redhat.com