search

kubevirt / vm-import-operator

Operator for importing VMs from RHV to KubeVirt
Apache License 2.0
16 stars 23 forks source link

Release v0.3.0 #460

Closed mansam closed 3 years ago

mansam commented 3 years ago

Signed-off-by: Sam Lucidi slucidi@redhat.com

kubevirt-bot commented 3 years ago

@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pkliczewski commented 3 years ago

@nunnatsa FYI

pkliczewski commented 3 years ago

@mansam please take a look at failing test:

Operator resource test Test CRD schemas /home/travis/gopath/src/github.com/kubevirt/vm-import-operator/pkg/operator/resources/operator/operator_test.go:42 [It] Test CRD schemas /home/travis/gopath/src/github.com/kubevirt/vm-import-operator/pkg/operator/resources/operator/operator_test.go:42 • Failure [0.040 seconds]

mansam commented 3 years ago

@pkliczewski That's the erroneous test failure I mentioned in https://github.com/kubevirt/vm-import-operator/pull/446. It's due to operator-utils' GetMissingEntries not handling pointers to metav1.Time. The times in the VirtualMachineImportStatus also generate the same errors, but the test ignores the status subresource so it's not noticed.

mansam commented 3 years ago

Investigating the Prow failure. Retesting to see if happens consistently.

/retest

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fdupont-redhat, jakub-dzon, mansam, pkliczewski To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-import-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pkliczewski commented 3 years ago

@pkliczewski That's the erroneous test failure I mentioned in #446. It's due to operator-utils' GetMissingEntries not handling pointers to metav1.Time. The times in the VirtualMachineImportStatus also generate the same errors, but the test ignores the status subresource so it's not noticed.

@jakub-dzon Would mind taking a look ^^

pkliczewski commented 3 years ago

@mansam Please push the new version of images