search

kubevirt / vm-import-operator

Operator for importing VMs from RHV to KubeVirt
Apache License 2.0
16 stars 23 forks source link

Fail import when V2V overlays can't be committed. #465

Closed mrnold closed 3 years ago

mrnold commented 3 years ago

Fixes part of https://bugzilla.redhat.com/show_bug.cgi?id=1904797

The "find" command does not fail when one "qemu-img commit" fails, so the changes from virt-v2v were not saved back to the VM disk in the presence of NFS permissions errors. The resulting VM was not able to boot because of the lack of virtio drivers in the initramfs.

This pull request uses an explicit loop to return an error in this case, which should at least stop the import from being marked as successful.

Fail import when V2V overlays can't be committed.
kubevirt-bot commented 3 years ago

Hi @mrnold. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrnold, pkliczewski To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-import-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment