search

kubevirt / vm-import-operator

Operator for importing VMs from RHV to KubeVirt
Apache License 2.0
16 stars 23 forks source link

Round disk size to 1Mi, instead of 512 bytes #508

Closed ghost closed 3 years ago

ghost commented 3 years ago

Since https://github.com/kubevirt/containerized-data-importer/pull/1873, Kubevirt's CDI rounds the disk size to 1MiB, instead of 512 bytes. This can lead to failure. This pull request enforces the same rounding in VMIO.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kubevirt-bot commented 3 years ago

@fdupont-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-vm-import-operator-e2e-k8s-1.18 c74a7c6c2ad8520611781c191597b28c4e0dede7 link /test pull-vm-import-operator-e2e-k8s-1.18
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fdupont-redhat, mansam

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/vm-import-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment