search

kubevirt / web-ui

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
26 stars 11 forks source link

Show warning/info when deleting disk/nic from running VM #100

Closed rawagner closed 4 years ago

rawagner commented 5 years ago

@lizsurette If I delete (and in the future edit) NIC or Disk from VM ( https://github.com/kubevirt/web-ui/pull/91 ) and the VM is running, the changes will not affect the running instance. Should we show warning or info that the changes will be applied to the new instance ?

lizsurette commented 5 years ago

@rawagner Definitely. We did some thinking on a similar workflow for oVirt where is the user makes a change that won't be applied until after a restart.

Do you think something like this would work where we let the user know that this change won't be applied until after a restart and then maybe some sort of notification above the table view?

oVirt Example confirmation modal: screen shot 2018-11-08 at 11 14 59 am

oVirt Example inline notification: screen shot 2018-11-08 at 11 15 23 am

@andybraren - What do you think?

andybraren commented 5 years ago

Sorry I'm late to this discussion. Good question, and I agree this is something we need to design for.

Here's the current NIC editor, for those following:

question-nic-click-confirm

@lizsurette In oVirt that confirmation modal seems to appear immediately after clicking the blue confirm button. I'm mostly okay with that, but if users click "Save Changes" and continue modifying other NICs/Disks I wouldn't want that modal to appear again. If it did there's a high likelihood they'd accidentally click the primary action (restart) while moving too quickly in annoyance.

I'd rather provide ambient indicators, like the inline notification, but also something more persistent. I think the VM's Status should change from "Running" with a green pficon-on-running icon to something slightly less positive, like an orange icon with an asterisk next to "Running", or maybe "Pending" if that's more appropriate. This feels like a use case PatternFly/OKD should have an icon for, but I'm not finding any that quite fit this scenario.

Here's a mockup of some Status ideas:

question-vm-changes-pending-status

Clicking the status could either bring the user to a log message describing the need to restart (similar to the way actual errors work) or display a tooltip with a brief message.

Does this make sense? I can get started mocking up the inline notification in the meanwhile.

lizsurette commented 5 years ago

Does this make sense? I can get started mocking up the inline notification in the meanwhile.

@andybraren I think a combination of the icon/state change and an inline notification would make it clear. You're right that we could probably avoid the pop-up and just let the user know that the changes haven't taken place yet and provide a quick way to restart via a link in the notification.

andybraren commented 5 years ago

I've proposed a new status icon in the design repo. It looks like this:

status-pending-changes

And here's what an inline notification could look like immediately after a NIC is added/modified. I think it should persist across all tab views, including the Overview, until the VM has been restarted.

4-1-3-add-edit-changed

kubevirt-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot commented 5 years ago

@kubevirt-bot: Closing this issue.

In response to [this](https://github.com/kubevirt/web-ui/issues/100#issuecomment-489359944): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rawagner commented 5 years ago

/remove-lifecycle rotten /reopen

kubevirt-bot commented 5 years ago

@rawagner: Reopened this issue.

In response to [this](https://github.com/kubevirt/web-ui/issues/100#issuecomment-495573171): >/remove-lifecycle rotten >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot commented 4 years ago

@kubevirt-bot: Closing this issue.

In response to [this](https://github.com/kubevirt/web-ui/issues/100#issuecomment-576009631): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.