search

kubevirt / web-ui

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
26 stars 11 forks source link

[OKD-core] Show VM, VMI, Migrations and various vm pod events in VM e… #170

Closed rawagner closed 5 years ago

rawagner commented 5 years ago

…vents page

https://bugzilla.redhat.com/show_bug.cgi?id=1659348

rawagner commented 5 years ago

LGTM except following:

  • can we introduce same OKD-core change to upstream? And search for another way in case it will not be accepted

sure, followup issue https://github.com/kubevirt/web-ui/issues/173 . I will prepare PR for tectonic.

  • can we unify to getResource() from #171?

rebased

I like the idea to have a single source of runtime informations (VM Events). I can even imagine, the events will be linked to the original source for more detailed analysis. WDYT?

thats already done by tectonic. Every event has title which links to its source. Or do you mean something else ?

With this change, we can expect the list of events becoming huge. Have you tried behaviour in this case, please?

I did and I think its manageable, at least it was in my case :) In the future we could also add resource filtering (show only events from pods/vm/vmi etc) and event type (error/info..) https://github.com/kubevirt/web-ui/issues/174