search

kubevirt / web-ui

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
26 stars 11 forks source link

Updates for node maintenance action #333

Closed rawagner closed 4 years ago

rawagner commented 5 years ago

Please correct me if I'm wrong, but my understanding is that the "Start Maintenance" action will only be available to hosts in Metal³, and not nodes?

Without the data rebuilding logic, this modal looks like what I would imagine a "Drain Node" modal would look like that triggers something like kubectl drain $nodename. That's probably fine for OKD, but IIRC draining a node without the data rebuilding logic isn't recommended in Metal³ since moving storage pods immediately could be a very long and expensive operation.

Regardless of that confusion, here's a mockup of how we could show a Maintenance reason for hosts in the UI. I agree that showing it when clicking the Under maintenance status is the best option. If no reason is given, nothing is shown in that area of the popover.

2b-1a-maint-modal

2a-2b-maint-status-messages

Originally posted by @andybraren in https://github.com/kubevirt/web-ui/pull/328#issuecomment-486444934

andybraren commented 5 years ago

My confusion about whether "maintenance" is a host or a node action is cleared up. It's definitely a node action.

This issue can probably be closed unless we want to track the "Maintenance reason" part of this design (which should include the new Status Popover pattern).

kubevirt-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot commented 4 years ago

@kubevirt-bot: Closing this issue.

In response to [this](https://github.com/kubevirt/web-ui/issues/333#issuecomment-582657615): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.