search

kubevirt / web-ui

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
26 stars 11 forks source link

Extract common dashboard functionality #361

Closed rawagner closed 5 years ago

rawagner commented 5 years ago

web-ui-components PR https://github.com/kubevirt/web-ui-components/pull/439

@gnehapk @AyushAmbastha @cloudbehl Can you please try this with the web-ui-components PR on environment with Cepth to make sure i didnt break anything ? Thank you

cloudbehl commented 5 years ago

@rawagner Ack! will test it and let you know.

cloudbehl commented 5 years ago

@rawagner Tested both(#361 and https://github.com/kubevirt/web-ui-components/pull/439) the PR. Looks good to me!

Screenshot from 2019-05-07 17-25-25

rawagner commented 5 years ago

@cloudbehl Thank you!

cloudbehl commented 5 years ago

@rawagner https://github.com/kubevirt/web-ui/pull/361/files#diff-f5fb6fd19d06f558ee1919e253b61608R154 was breaking earlier when I pulled it but later looks like you fixed it.