search

kubevirt / web-ui

OpenShift Cluster Console UI
https://www.openshift.org
Apache License 2.0
26 stars 11 forks source link

add test for non-admin user #415

Closed gouyang closed 5 years ago

gouyang commented 5 years ago

Implementation of Polarion test case: https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-1718 https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-1720

Comments for review:

  1. It's using UI to create the test project, it's more convenient than do it via cli.

Signed-off-by: Guohua Ouyang gouyang@redhat.com

atiratree commented 5 years ago

Also, there is other functionality which should be tested for permissions / missing resources. This functionality could be a nice followup

gouyang commented 5 years ago

@suomiy @rhrazdil I made some changes, could you please review again?

mareklibra commented 5 years ago

@gouyang , have you considered implementing new tests in openshift-console, please?

There will be no other build of web-ui (except bug-fixes for 2.0.0). And as we have migrated almost all features from here to upstream already, we are moving integration tests is in progress as well these days.

So targeting openshift-console directly sounds more effective to me atm.

gouyang commented 5 years ago

@gouyang , have you considered implementing new tests in openshift-console, please?

There will be no other build of web-ui (except bug-fixes for 2.0.0). And as we have migrated almost all features from here to upstream already, we are moving integration tests is in progress as well these days.

So targeting openshift-console directly sounds more effective to me atm.

I'm okay to move this to openshift-console, will move it over after address the review comments.

gouyang commented 5 years ago

Moved this to https://github.com/openshift/console/pull/2265, will close this.