Closed mareklibra closed 5 years ago
@lizsurette do you agree a spinner is a good choice here?
@jelkosz @mareklibra We are going to do a quick pass at a design for this flow and will share soon!
Hi @mareklibra, @jelkosz, @lizsurette, please take a look at these 2 options:
Ref. to the PF spinner: https://www.patternfly.org/pattern-library/widgets/#spinner
do we have a way to do proper time estimates? AFAIU we can't have a reliable progress indication (e.g. not time based nor step 1 / 10) @jelkosz ?
I dont thinw we have anything reliable.
In that case we might just omit this line?
On Mon, Oct 29, 2018 at 5:30 PM Tomas Jelinek notifications@github.com wrote:
I dont thinw we have anything reliable.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kubevirt/web-ui/issues/45#issuecomment-433954276, or mute the thread https://github.com/notifications/unsubscribe-auth/AqgyjM7zV_ui4J1ifWavAOuCGyMcXL5Rks5upx8YgaJpZM4XtQcB .
+1
In the first image, what does the progress bar indicate? How do you calculate in which position should it be at?
On Mon, Oct 29, 2018, 6:51 PM Yifat Friman Menchik notifications@github.com wrote:
[image: vm_startinprogop1 2] https://user-images.githubusercontent.com/44577420/47665961-1ac7ea80-dbab-11e8-8988-db0bfa2af6b6.png
[image: vm_startinprogop2 2] https://user-images.githubusercontent.com/44577420/47665962-1b608100-dbab-11e8-96e9-754c8b58f1fa.png
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kubevirt/web-ui/issues/45#issuecomment-433986925, or mute the thread https://github.com/notifications/unsubscribe-auth/AABOx65uD0cSbsOYV-F-OlBe1qQ1j4jiks5upzIigaJpZM4XtQcB .
It should indicate the remaining time for the console to be available.
I don't think there is any way for us to guesstimate the remaining time, unless @mareklibra knows something more.
or we could reuse loading style from tectonic
@rawagner Great point, we should probably use the Tectonic loading GIF rather than PatternFly until we switch all of the loading GIFs in the console over to PatternFly :)
I don't think there is any way for us to guesstimate the remaining time, unless @mareklibra knows something more.
We can "step over" phases required for launching a VM but I don't think this make any sense from the user perspective (some of them are super fast, some can get stuck). So I am for the neutral spinner/GIF.
Following is for a new GH issue, but is related.
When developing the Consoles
tab, I faced an issue when the pod got stuck in the Scheduling
phase due to cluster misconfiguration (but could be whatever else).
I had feeling I should keep waiting. After curious visiting the Events
page I saw it would take forever. We should reflect such issues in the UI more visibly, not just part of the Events
.
Following is for a new GH issue, but is related. When developing the
Consoles
tab, I faced an issue when the pod got stuck in theScheduling
phase due to cluster misconfiguration (but could be whatever else). I had feeling I should keep waiting. After curious visiting theEvents
page I saw it would take forever. We should reflect such issues in the UI more visibly, not just part of theEvents
.
@mareklibra This came up in another thread as well as @rawagner was trying to run a VM with an additional disk which uses the volume PVC type (VM and PVC definition attached). Turns out it was a permissions issue that was shown in the Events, but wasn't surfaced well to the user. Would you guys like me to log a different issue for these cases? Or is there something that already exists to track it?
So I am for the neutral spinner/GIF.
+1 to simply sticking with the loading GIF rather than trying to introduce any sort of progress for now.
@mareklibra This came up in another thread as well as @rawagner was trying to run a VM with an additional disk which uses the volume PVC type (VM and PVC definition attached). Turns out it was a permissions issue that was shown in the Events, but wasn't surfaced well to the user. Would you guys like me to log a different issue for these cases? Or is there something that already exists to track it?
just opened it: https://github.com/kubevirt/web-ui/issues/77
The VM console (recently VNC, but others will come) requires running VMI to connect to. If none is available, the user is instructed to start the VM.
For the case when VMI is not running, but VM start is in progress (like
scheduling
), the message should reflect this phase and show spinner.