search

kubewarden / allowed-proc-mount-types-psp-policy

Replacement for the Kubernetes Pod Security Policy that controls the usage of /proc mount types
https://kubewarden.io
Apache License 2.0
7 stars 5 forks source link

feat: Update `artifacthub-pkg.yml` automatically from now on #24

Closed geeksambhu closed 1 year ago

geeksambhu commented 1 year ago

Description

Consume github-actions@v2. Add new make artifacthub-pkg.yml target, make needed changes to metadata.yml, and recreate artifacthub-pkg.yml.

Relates to https://github.com/kubewarden/kubewarden-controller/issues/389

Test

CI job check-artifacthub should pass, among all the others.

Additional Information

Tradeoff

Potential improvement

jvanz commented 1 year ago

@geeksambhu thank you for the help on this! :)

I've left some comments in the changes. Sorry for all of them, in a recent talk during our planning meeting we decided to do some things a little bit different. You are doing great.

geeksambhu commented 1 year ago

Thanks, @jvanz for your insightful feedback. I have incorporated your feedback and updated the PR. Kindly review :)

viccuad commented 1 year ago

by the run of the CI, I realize that there's no "check artifacthub" job. This is because we haven't updated the .github/workflows/test.yml job. I didn't do it either on my first PR :facepalm:

Can you update .github/workflows/test.yml to consume the github reusable workflow too? It would be a change like the one in this commit, in a different PR: https://github.com/kubewarden/volumeMounts-policy/pull/18/commits/99f969fab7f820fef63aa22824e185f212732693#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88

viccuad commented 1 year ago

Closing, superseded by https://github.com/kubewarden/allowed-proc-mount-types-psp-policy/pull/27.