search

kubewarden / cel-policy

A policy that can run CEL expressions
Apache License 2.0
5 stars 5 forks source link

chore: install wasm-opt automatically #79

Closed jvanz closed 2 months ago

jvanz commented 2 months ago

Description

Updates the Makefile to install the wasm-opt command automatically in the bin directory. Following a similar approach to the go linter. Therefore, the user does not need to install it manually.

fabriziosestito commented 2 months ago

I've mixed feelings about that, since I install wasm-opt via binaryen and keep the whole binaryen package updated via package manager.

I fear this binary could become stale over the time

@flavio @jvanz, not a strong opinion but I would also try to avoid maintaining another tool version as it doesn't change so much.

jvanz commented 2 months ago

Fair enough. Closing this.