search

kubewarden / docs

Kubewarden's documentation
https://docs.kubewarden.io
Creative Commons Attribution 4.0 International
13 stars 23 forks source link

feat: PolicyServer PodDisruptionBudget documentation. #386

Closed jvanz closed 6 months ago

jvanz commented 6 months ago

Description

Add documentation to describe the minAvailable and maxUnavailable fields in the policy server spec.

Fix https://github.com/kubewarden/kubewarden-controller/issues/692

netlify[bot] commented 6 months ago

Deploy Preview for silly-bunny-8cedd0 ready!

Name Link
Latest commit 155ebcf5c7cb8733fec530155af12b83df6b1f7b
Latest deploy log https://app.netlify.com/sites/silly-bunny-8cedd0/deploys/6613c065a3e5d900086dc3f2
Deploy Preview https://deploy-preview-386--silly-bunny-8cedd0.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ferhatguneri commented 6 months ago

@jvanz I see no changes in src. This is only doc change and how are you expecting people to add this to their kubewarden-controller helm chart ?

jvanz commented 6 months ago

@jvanz I see no changes in src. This is only doc change and how are you expecting people to add this to their kubewarden-controller helm chart ?

There are a bunch of PR changing the controller and the Helm charts:

https://github.com/kubewarden/helm-charts/pull/414/files https://github.com/kubewarden/kubewarden-controller/pull/698

flavio commented 6 months ago

@jvanz don't you have to add it to the sidebar too?

jvanz commented 6 months ago

@jvanz don't you have to add it to the sidebar too?

It's already in the sidebar

image

jhkrug commented 6 months ago

@jvanz don't you have to add it to the sidebar too?

Hi @flavio, the big reorg a while back got rid of all that mess. The structure is defined in the file system, just put a new doc in the right place, make sure the title, sidebar_title and possibly sidebar_position are as needed in the front matter, sidebar get's auto generated and Bob's your uncle, easy peasy, etc. https://en.wikipedia.org/wiki/Bob%27s_your_uncle. I may have neglected to emphasize this detail at the time.