Per chart, historically we have had an internal values file, chart-values.yaml, that is concatenated with common-values.yaml which contains the values fields that are the same for both kubewarden-controller and kubewarden-defaults chart.
To make sure that the chart/*/values.yaml don't diverge from the fields in common-values.yaml, we had the make generate-values, make check-generated-values targets.
This non-standard, obtuse, and a stumbling point for all new contributors.
Acceptance criteria
Remove chart-values.yaml for all charts, only having the values.yaml file per chart.
Remove make generate-values, not needed anymore, values.yaml will be the canonical ones.
Remove make check-generated-values, use the already existing make check-common-values. The latter checks that the contents of common-values.yaml are included in values.yaml.
Migrate CI and chart PR automation from make check-generated-values to make check-common-values.
Per chart, historically we have had an internal values file,
chart-values.yaml, that is concatenated withcommon-values.yamlwhich contains the values fields that are the same for bothkubewarden-controllerandkubewarden-defaultschart.To make sure that the
chart/*/values.yamldon't diverge from the fields incommon-values.yaml, we had themake generate-values,make check-generated-valuestargets.This non-standard, obtuse, and a stumbling point for all new contributors.
Acceptance criteria
make generate-values, not needed anymore, values.yaml will be the canonical ones.make check-generated-values, use the already existingmake check-common-values. The latter checks that the contents of common-values.yaml are included in values.yaml.make check-generated-valuestomake check-common-values.